Fix #142: SendUseroperationWithDelegation still references AccountMeta#157
Open
patchy-the-bot wants to merge 2 commits intoMetaMask:mainfrom
Open
Conversation
jeffsmale90
reviewed
Feb 17, 2026
packages/delegator-e2e/test/actions/erc7710sendUserOperationWithDelegation.test.ts
Outdated
Show resolved
Hide resolved
packages/delegator-e2e/test/actions/erc7710sendUserOperationWithDelegation.test.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #142 by aligning
sendUserOperationWithDelegationwith the amended ERC-7715 schema. The deprecatedaccountMetadatafield has been fully replaced withdependencies, ensuring the smart accounts flow matches the standard definition and prevents future incompatibilities when Permission responses start returning dependency data.Changes
erc7710RedeemDelegationAction.tsto accept and validatedependencies, including renaming helper variables, error messages, and inlined documentation/comments.dependencies, preserving the previous behavior while matching the ERC-7715 terminology.Testing
yarn testFixes #142
Note
Medium Risk
This changes the public parameter shape for
sendUserOperationWithDelegation, which can break downstream callers and alters pre-call validation logic for factory deployment dependencies; runtime behavior should otherwise remain equivalent.Overview
Updates
sendUserOperationWithDelegationActionto acceptdependencies(instead of the deprecatedaccountMetadata) and uses it to validate allowed factories, dedupe repeated entries, and prepend any required factory deployment calls before sending the user operation.Renames related terminology in inline docs/comments and updates unit tests plus delegator E2E coverage to use
dependenciesand expect the new error message (Invalid dependency: ...).Written by Cursor Bugbot for commit 129e622. This will update automatically on new commits. Configure here.