Skip to content

Fix #142: SendUseroperationWithDelegation still references AccountMeta#157

Open
patchy-the-bot wants to merge 2 commits intoMetaMask:mainfrom
patchy-the-bot:patchy/issue-142-senduseroperationwithdelegatio
Open

Fix #142: SendUseroperationWithDelegation still references AccountMeta#157
patchy-the-bot wants to merge 2 commits intoMetaMask:mainfrom
patchy-the-bot:patchy/issue-142-senduseroperationwithdelegatio

Conversation

@patchy-the-bot
Copy link
Contributor

@patchy-the-bot patchy-the-bot commented Feb 16, 2026

Summary

Fixes #142 by aligning sendUserOperationWithDelegation with the amended ERC-7715 schema. The deprecated accountMetadata field has been fully replaced with dependencies, ensuring the smart accounts flow matches the standard definition and prevents future incompatibilities when Permission responses start returning dependency data.

Changes

  • Updated erc7710RedeemDelegationAction.ts to accept and validate dependencies, including renaming helper variables, error messages, and inlined documentation/comments.
  • Adjusted the smart accounts kit unit tests and delegator e2e suites to reflect the new parameter name and to cover duplicate dependency handling.
  • Ensured the generated factory call logic now operates on deduplicated dependencies, preserving the previous behavior while matching the ERC-7715 terminology.

Testing

  • yarn test

Fixes #142


Note

Medium Risk
This changes the public parameter shape for sendUserOperationWithDelegation, which can break downstream callers and alters pre-call validation logic for factory deployment dependencies; runtime behavior should otherwise remain equivalent.

Overview
Updates sendUserOperationWithDelegationAction to accept dependencies (instead of the deprecated accountMetadata) and uses it to validate allowed factories, dedupe repeated entries, and prepend any required factory deployment calls before sending the user operation.

Renames related terminology in inline docs/comments and updates unit tests plus delegator E2E coverage to use dependencies and expect the new error message (Invalid dependency: ...).

Written by Cursor Bugbot for commit 129e622. This will update automatically on new commits. Configure here.

@patchy-the-bot patchy-the-bot requested a review from a team as a code owner February 16, 2026 23:49
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SendUseroperationWithDelegation still references AccountMeta

2 participants