feat: Detect unused permissions in Snaps CLI#3335
Merged
Conversation
232d1f1 to
d58f62c
Compare
Mrtenz
commented
May 2, 2025
76e0caa to
bef9728
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3335 +/- ##
==========================================
+ Coverage 98.12% 98.13% +0.01%
==========================================
Files 399 400 +1
Lines 10961 11027 +66
Branches 1725 1738 +13
==========================================
+ Hits 10755 10821 +66
Misses 206 206 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bef9728 to
4d9ea6a
Compare
938fb47 to
d6538d5
Compare
Mrtenz
commented
May 21, 2025
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
FrederikBolding
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds unused permission detection for handlers to the Snaps CLI. It will detect two cases:
Unfortunately due to how it works, it did require some refactors to the CLI:
manifestcommand as well.