Skip to content

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented May 2, 2025

Browserify is not actively maintained and we should stop recommending it. With the removal of Browserify from #3322, we can now completely remove Browserify from the repo.

@metamask/snaps-browserify-plugin should be deprecated on NPM after merging this.

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedupdate-browserslist-db@​1.1.3 ⏵ 1.1.21001007481100
Updatedcaniuse-lite@​1.0.30001716 ⏵ 1.0.300016991001007498 +1100
Updatedelectron-to-chromium@​1.5.149 ⏵ 1.5.9810010010096100

View full report

@codecov
Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (1d36a99) to head (620ac52).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3372      +/-   ##
==========================================
- Coverage   98.03%   98.03%   -0.01%     
==========================================
  Files         402      397       -5     
  Lines       11107    10899     -208     
  Branches     1754     1714      -40     
==========================================
- Hits        10889    10685     -204     
+ Misses        218      214       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mrtenz Mrtenz marked this pull request as ready for review May 2, 2025 12:49
@Mrtenz Mrtenz requested a review from a team as a code owner May 2, 2025 12:49
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite get the policy changes here, mind explaining?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency graph changed slightly since I removed some Babel packages, which caused other Babel packages to be bumped. I think we now have two versions of @babel/types in the graph, and LavaMoat's algorithm seems to prefer the new one. There are no actual new capabilities added to any package here.

@Mrtenz Mrtenz requested a review from hmalik88 May 2, 2025 18:41
@Mrtenz Mrtenz added this pull request to the merge queue May 2, 2025
Merged via the queue into main with commit d87cf44 May 2, 2025
115 checks passed
@Mrtenz Mrtenz deleted the mrtenz/remove-browserify-plugin branch May 2, 2025 19:21
github-merge-queue bot pushed a commit that referenced this pull request May 5, 2025
Update the graph in the README following
#3372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants