Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented May 5, 2025

This PR fixes two issues:

Firstly, we were not catching errors thrown during the "daily checkin" of the CronjobController, this means that if one Snap failed we would not complete the initialization of the controller and no cronjobs would run.

Secondly, we were running all the cronjobs sequentially during "daily check" which seems unintentional given that we don't need the result of the cronjob invocation.

@codecov
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (d87cf44) to head (a5c5244).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3373      +/-   ##
==========================================
+ Coverage   98.03%   98.06%   +0.02%     
==========================================
  Files         397      397              
  Lines       10899    10898       -1     
  Branches     1714     1714              
==========================================
+ Hits        10685    10687       +2     
+ Misses        214      211       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding marked this pull request as ready for review May 5, 2025 10:25
@FrederikBolding FrederikBolding requested a review from a team as a code owner May 5, 2025 10:25
@FrederikBolding FrederikBolding enabled auto-merge May 5, 2025 10:25
@FrederikBolding FrederikBolding added this pull request to the merge queue May 5, 2025
Merged via the queue into main with commit 37e79af May 5, 2025
115 checks passed
@FrederikBolding FrederikBolding deleted the fb/catch-cronjob-init-errors branch May 5, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants