Jl/wip mm connect #41
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,135 @@ | ||
| /* eslint-disable */ | ||
|
|
||
| import { | ||
| type InvokeMethodOptions, | ||
| type MultichainCore, | ||
| type SDKState, | ||
| type Scope, | ||
| type SessionData, | ||
| createMultichainClient, | ||
| getInfuraRpcUrls, | ||
| } from '@metamask/connect-multichain'; | ||
| import type { MultichainApiClient } from '@metamask/multichain-api-client'; | ||
| import type { CaipAccountId } from '@metamask/utils'; | ||
| import type React from 'react'; | ||
| import { createContext, useCallback, useContext, useEffect, useRef, useState } from 'react'; | ||
|
|
||
| const METAMASK_PROD_CHROME_ID = 'nkbihfbeogaeaoehlefnkodbefgpgknn'; | ||
|
|
||
| const SDKContext = createContext< | ||
| | { | ||
| session: SessionData | undefined; | ||
| state: SDKState; | ||
| error: Error | null; | ||
| connect: (scopes: Scope[], caipAccountIds: CaipAccountId[]) => Promise<void>; | ||
| disconnect: () => Promise<void>; | ||
| invokeMethod: (options: InvokeMethodOptions) => Promise<any>; | ||
| getProvider: () => Promise<MultichainApiClient>; | ||
| } | ||
| | undefined | ||
| >(undefined); | ||
|
|
||
| export const SDKProvider = ({ children }: { children: React.ReactNode }) => { | ||
| const [state, setState] = useState<SDKState>('pending'); | ||
| const [session, setSession] = useState<SessionData | undefined>(undefined); | ||
| const [error, setError] = useState<Error | null>(null); | ||
|
|
||
| const sdkRef = useRef<Promise<MultichainCore>>(undefined); | ||
|
|
||
| useEffect(() => { | ||
| if (!sdkRef.current) { | ||
| sdkRef.current = createMultichainClient({ | ||
| dapp: { | ||
| name: 'playground', | ||
| url: 'https://playground.metamask.io', | ||
| }, | ||
| api: { | ||
| supportedNetworks: getInfuraRpcUrls(process.env.INFURA_API_KEY || ''), | ||
|
There was a problem hiding this comment. Environment variable inaccessible in Vite browser contextMedium Severity The code uses |
||
| }, | ||
| transport: { | ||
| extensionId: METAMASK_PROD_CHROME_ID, | ||
| onNotification: (notification: unknown) => { | ||
| const payload = notification as Record<string, unknown>; | ||
| if ( | ||
| payload.method === 'wallet_sessionChanged' || | ||
| payload.method === 'wallet_createSession' || | ||
| payload.method === 'wallet_getSession' | ||
| ) { | ||
| setSession(payload.params as SessionData); | ||
| } else if (payload.method === 'stateChanged') { | ||
| setState(payload.params as SDKState); | ||
| } | ||
| }, | ||
| }, | ||
| }); | ||
| } | ||
| }, []); | ||
|
|
||
| const disconnect = useCallback(async () => { | ||
| try { | ||
| if (!sdkRef.current) { | ||
| throw new Error('SDK not initialized'); | ||
| } | ||
| const sdkInstance = await sdkRef.current; | ||
| return sdkInstance.disconnect(); | ||
| } catch (error) { | ||
| setError(error as Error); | ||
| } | ||
| }, []); | ||
|
|
||
| const connect = useCallback(async (scopes: Scope[], caipAccountIds: CaipAccountId[]) => { | ||
| try { | ||
| if (!sdkRef.current) { | ||
| throw new Error('SDK not initialized'); | ||
| } | ||
| const sdkInstance = await sdkRef.current; | ||
| await sdkInstance.connect(scopes, caipAccountIds); | ||
| } catch (error) { | ||
| setError(error as Error); | ||
| } | ||
| }, []); | ||
|
|
||
| const invokeMethod = useCallback(async (options: InvokeMethodOptions) => { | ||
| try { | ||
| if (!sdkRef.current) { | ||
| throw new Error('SDK not initialized'); | ||
| } | ||
| const sdkInstance = await sdkRef.current; | ||
| return sdkInstance.invokeMethod(options); | ||
| } catch (error) { | ||
| setError(error as Error); | ||
| } | ||
| }, []); | ||
|
|
||
| const getProvider = useCallback(async () => { | ||
| if (!sdkRef.current) { | ||
| throw new Error('SDK not initialized'); | ||
| } | ||
| const sdkInstance = await sdkRef.current; | ||
| return sdkInstance.provider as MultichainApiClient; | ||
| }, []); | ||
|
There was a problem hiding this comment. Inconsistent error handling in
|
||
|
|
||
| return ( | ||
| <SDKContext.Provider | ||
| value={{ | ||
| session, | ||
| state, | ||
| error, | ||
| connect, | ||
| disconnect, | ||
| invokeMethod, | ||
| getProvider, | ||
| }} | ||
| > | ||
| {children} | ||
| </SDKContext.Provider> | ||
| ); | ||
| }; | ||
|
|
||
| export const useSDK = () => { | ||
| const context = useContext(SDKContext); | ||
| if (context === undefined) { | ||
| throw new Error('useSDK must be used within a SDKProvider'); | ||
| } | ||
| return context; | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Local file dependencies break builds in non-local environments
High Severity
The
resolutionsanddependenciescontain local file paths likefile:../connect-monorepo/packages/connect-multichainthat reference a sibling directory. These paths will fail in CI/CD pipelines, other developers' machines, and production builds since the expected local directory structure won't exist. This appears to be development-time configuration that was accidentally included in the PR.