Open
Conversation
mcmire
reviewed
Dec 14, 2022
Gudahtt
reviewed
Jan 12, 2023
586eadb to
5422dc3
Compare
5422dc3 to
cf1822c
Compare
mcmire
reviewed
Feb 7, 2023
Member
|
In a recent PR, the source code for the old "Collectibles" contract was added to the repository (in the |
Gudahtt
reviewed
Feb 9, 2023
8 tasks
cf1822c to
c7f03b7
Compare
Gudahtt
reviewed
Feb 15, 2023
| @@ -1,25 +1,21 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| pragma solidity >=0.4.22 <0.9.0; | |||
|
|
|||
| import "@openzeppelin/contracts/token/ERC721/ERC721.sol"; | |||
Member
There was a problem hiding this comment.
Hmm, I tried compiling this in Remix but got an error about Strings already being declared. I don't quite understand why, but, it went away with I removed the @4.8.1 or added it to the other two imports. Perhaps they should all be using the same version of @openzeppelin/contracts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to update
collectiblestonfts.Reference: MetaMask/metamask-extension#16889
Code for Abis and bytecode: