Skip to content

Removed peer dependancy because of error#5

Open
tgrrr wants to merge 1 commit intoMicheleBertoli:masterfrom
tgrrr:master
Open

Removed peer dependancy because of error#5
tgrrr wants to merge 1 commit intoMicheleBertoli:masterfrom
tgrrr:master

Conversation

@tgrrr
Copy link

@tgrrr tgrrr commented Sep 24, 2018

Removed the peerDependancy because when we install with yarn, the following error occurs:

warning " > react-fix-it@0.3.3" has incorrect peer dependency "react@^15.4.1".

Error:
```
warning " > react-fix-it@0.3.3" has incorrect peer dependency "react@^15.4.1".
```
@MicheleBertoli
Copy link
Owner

Thank you very much for opening this PR, @tgrrr.

I assume yarn is showing you a warning because you are using a different version of React.
I'm OK with bumping the React version (if this package still works), but I wouldn't remove the peer dependency.

I hope this makes sense.

@tgrrr
Copy link
Author

tgrrr commented Oct 24, 2018

@MicheleBertoli thanks.

Since I've done this PR, I've come across a few accounts of yarn peer dependency bugs, so it might also be that. Eg. yarnpkg/yarn#4433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants