v2.0 🎉 🎉 🎉

[AnatoleLucet]

No description provided.

[MicheleBertoli]

Awesome stuff, well done @AnatoleLucet
I left a few comments, please let me know if they make sense

I also have a couple of questions:

• could you please add the instructions to install/run the package and the examples?
• I see that there's no tests right now, may I ask what's the plan?

[AnatoleLucet]

Thanks for taking the time to review this whole pr 🙏

could you please add the instructions to install/run the package and the examples?

Yes, I'm planning on writing the doc in the readme and make a contributing.md file.

I see that there's no tests right now, may I ask what's the plan?

I was planning on writing tests cases mainly for the lib/ folder and maybe a few for components/ and hooks/.
Since components/ and hooks/ are tightly coupled with google-maps, it might be a bit complicated to write complete tests suits for them. I'll see what's possible, but if you have any advice, I'm more than interested!

[MicheleBertoli]

Hello @AnatoleLucet, and thanks once again for the outstanding work on the v2.
I love the simplicity and intuitiveness of the API, the docs, and the examples so much :)

I spent some time reviewing the PR and left a few comments - please let me know if they make sense.

Happy to merge and ship under next (and explore a testing strategy in parallel).

[MicheleBertoli]

npm install react-gmaps@next 🚀🚀🚀

[MicheleBertoli]

It seems there's a little formatting issue on examples/basic/pnpm-lock.yaml
Do we want to fix it before merging? (just to get all the lights green :))

Thanks once again for the excellent work, feel free to merge into master in your own time.

[MicheleBertoli]

FYI I'm playing around with Cypress (running the marker example and checking that the marker is there)

[AnatoleLucet]

Hey @MicheleBertoli
Amazing! Thanks for releasing the new version! 🎉 🎉

I fixed the CI and pushed a few small changes. I think you need to approve the PR for me to be able to merge it, but feel free to merge!

[MicheleBertoli]

🙌

[MicheleBertoli]

I just notice this - I believe it should be const polygon.

Double-check that events are working

[MicheleBertoli]

@AnatoleLucet, sorry for putting this back in your queue.

However, as I was working on e2e tests, I noticed that events don't seem to be working.
Repro: add onClick={() => console.log("clicked")} to GMapsMarker in marker example.

From a quick look, it seems the issue is that the hook that adds the event listeners only runs on updates.
In fact, it works when the component re-renders.

I hope this makes sense, and happy to provide more context if valuable.

[AnatoleLucet]

Interesting. Good thing we're going to have test cases for this then 😅
Thanks for the feedback, i'll check as soon as possible 🙏