-
Notifications
You must be signed in to change notification settings - Fork 266
Re-scopes at-rule #1231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
diekus
wants to merge
10
commits into
MicrosoftEdge:main
Choose a base branch
from
diekus:diekus-at-rule
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Re-scopes at-rule #1231
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b49526c
Adds security-privacy questionnaire
diekus 7c17318
Update AtRuleFeatureDetection/security-privacy-questionnaire.md
diekus e3fa1da
Update AtRuleFeatureDetection/security-privacy-questionnaire.md
diekus 883888e
Update AtRuleFeatureDetection/security-privacy-questionnaire.md
diekus df514ac
Rescopes at-rule down to test to just `at-rule(@foo)`
diekus 64bfcd3
Update explainer.md
diekus 98311b4
Addresses TAG comments
diekus 88aa986
Merge branch 'MicrosoftEdge:main' into diekus-at-rule
diekus 340fff3
Update explainer.md
diekus 4789512
Update explainer.md
diekus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than deleting these, should we move them to Non-Goals, with a note that the CSSWG resolved to introduce
@supports-conditionto handle them? And perhaps a link to the spec: https://drafts.csswg.org/css-conditional-5/#supports-condition-rule