Add Greeting component to display a personalized welcome message#1
Open
SyedArslanHaider wants to merge 4 commits intomainfrom
Open
Add Greeting component to display a personalized welcome message#1SyedArslanHaider wants to merge 4 commits intomainfrom
SyedArslanHaider wants to merge 4 commits intomainfrom
Conversation
src/App.jsx
Outdated
| @@ -2,13 +2,15 @@ import { useState } from 'react' | |||
| import reactLogo from './assets/react.svg' | |||
| import viteLogo from '/vite.svg' | |||
Collaborator
There was a problem hiding this comment.
This needs tobe cleared.
Kindly delete it.
src/App.jsx
Outdated
| import Greeting from './Greeting'; | ||
|
|
||
| function App() { | ||
| const [count, setCount] = useState(0) |
Collaborator
There was a problem hiding this comment.
Kindly clear this useState.It is not being used.
src/App.jsx
Outdated
| <> | ||
| <div> | ||
| <Greeting name="Arslan Haider"/> | ||
| <a href="https://vite.dev" target="_blank"> |
Collaborator
There was a problem hiding this comment.
Kindly clear this too
| @@ -0,0 +1,5 @@ | |||
| function Greeting({ name }) { | |||
Collaborator
There was a problem hiding this comment.
where is your styling for this component?
Kindly add your styling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.