Migracode|Afere Precious Onome|Task Manager Exercise.#2
Open
AferePreciousOnome wants to merge 4 commits intoMigracode-Barcelona:mainfrom
Open
Migracode|Afere Precious Onome|Task Manager Exercise.#2AferePreciousOnome wants to merge 4 commits intoMigracode-Barcelona:mainfrom
AferePreciousOnome wants to merge 4 commits intoMigracode-Barcelona:mainfrom
Conversation
Contributor
nicostuhlfauth
left a comment
nicostuhlfauth
left a comment
There was a problem hiding this comment.
Hey @AferePreciousOnome 👋,
congrats on your first React PR! This looks quite good, I just left you a few comments.
General recommendations:
- do not overuse props: if we always want the same behavior, we can directly create it as part of the component. If we need more flexibility later, we can always change that.
- you could simplify your styles, for examples creating a new class containing all shared styles of the colorBoxes, like height, width, everything not related to the color.
Comment on lines
64
to
65
| photos: PropTypes.arrayOf(PropTypes.string).isRequired, | ||
| studentPhotos: PropTypes.arrayOf(PropTypes.string).isRequired, |
Contributor
There was a problem hiding this comment.
Suggested change
| photos: PropTypes.arrayOf(PropTypes.string).isRequired, | |
| studentPhotos: PropTypes.arrayOf(PropTypes.string).isRequired, |
…o limited the use of props.
-Which Include a form -Added `.trim` to remove white spaces from input. -Stopped submission if it contains only whitespace. -Ensured input field reset after adding a task.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made the changes you suggested.