Skip to content

fix: Corrects hit testing in iOS 26 to prevent tap misses #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alina-p-k merged 2 commits into from
Oct 12, 2025
Merged

fix: Corrects hit testing in iOS 26 to prevent tap misses #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7796e0d
fix: Fixed the issue with hitTest
alina-p-k Oct 12, 2025
d424b55
Update CI/CD
alina-p-k Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions .github/workflows/publish-to-cocoapods.yml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: Run tests
run: xcodebuild test -scheme MijickPopups -destination 'platform=iOS Simulator,OS=18.0,name=iPhone 16 Pro'
run: xcodebuild test -scheme MijickPopups -destination 'platform=iOS Simulator,OS=18.5,name=iPhone SE (3rd generation)'
4 changes: 3 additions & 1 deletion Sources/Public/Setup/Public+Setup+SceneDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,14 +113,16 @@ private extension Window {
@available(iOS 26, *)
func hitTest_iOS26(_ point: CGPoint, with event: UIEvent?) -> UIView? {
guard let rootView = self.rootViewController?.view else { return nil }
guard let isDismissParameterEmpty = PopupStackContainer.stacks.first?.popups.last?.config.isTapOutsideToDismissEnabled else { return nil }

let pointInRootView = self.convert(point, to: rootView)
let hitView = rootView.hitTest(pointInRootView, with: event)
let isTapOutsideToDismissEnabled = PopupStackContainer.stacks.first?.popups.last?.config.isTapOutsideToDismissEnabled ?? false

if hitView == rootView || hitView == nil { return isTapOutsideToDismissEnabled ? rootView : nil }
if hitView == rootView || hitView == nil { return isTapOutsideToDismissEnabled ? rootView : hitView }
return hitView
}

@available(iOS 18, *)
func hitTest_iOS18(_ point: CGPoint, with event: UIEvent?) -> UIView? {
super.hitTest(point, with: event)
Expand Down