-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Reorder workspace threads by latest interaction #4857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Reorder workspace threads by latest interaction #4857
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for basic inference but doesn't work for agent chats and a couple different edge cases. See this comment:
frontend/src/components/Sidebar/ActiveWorkspaces/ThreadContainer/index.jsx
Outdated
Show resolved
Hide resolved
angelplusultra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Only nitpick would be maybe this:
if (threadSlug) {
window.dispatchEvent(
new CustomEvent(THREAD_ACTIVITY_EVENT, {
detail: { threadSlug },
})
);
}is written multiple times around, maybe abstract to a utility fn?
export function dispatchThreadActivityEvent(threadId){
if (threadSlug) {
window.dispatchEvent(
new CustomEvent(THREAD_ACTIVITY_EVENT, {
detail: { threadSlug },
})
);
}
}|
Fixed code duplication problem by creating reusable |
frontend/src/components/Sidebar/ActiveWorkspaces/ThreadContainer/index.jsx
Show resolved
Hide resolved
angelplusultra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request Type
Relevant Issues
resolves #4844
What is in this change?
Additional Information
Developer Validations
yarn lintfrom the root of the repo & committed changes