Skip to content

Conversation

@shatfield4
Copy link
Collaborator

@shatfield4 shatfield4 commented Jan 13, 2026

Pull Request Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ”¨ chore
  • πŸ“ docs

Relevant Issues

resolves #4844

What is in this change?

  • Returns threads in descending order
  • On chat sent we reorder the threads to put latest interacted with threads at the top
  • Add subtle bump animation on reorder
  • Handles normal chat, query chat (with no context found), agent chat, and slash commands

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

Copy link
Contributor

@angelplusultra angelplusultra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for basic inference but doesn't work for agent chats and a couple different edge cases. See this comment:

#4857 (comment)

Copy link
Contributor

@angelplusultra angelplusultra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only nitpick would be maybe this:

    if (threadSlug) {
      window.dispatchEvent(
        new CustomEvent(THREAD_ACTIVITY_EVENT, {
          detail: { threadSlug },
        })
      );
    }

is written multiple times around, maybe abstract to a utility fn?

export function dispatchThreadActivityEvent(threadId){
   if (threadSlug) {
      window.dispatchEvent(
        new CustomEvent(THREAD_ACTIVITY_EVENT, {
          detail: { threadSlug },
        })
      );
    }
}

@shatfield4
Copy link
Collaborator Author

Fixed code duplication problem by creating reusable dispatchThreadActivityEvent method. Assigned back to you @angelplusultra.

Copy link
Contributor

@angelplusultra angelplusultra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shatfield4 shatfield4 removed their assignment Jan 14, 2026
@timothycarambat timothycarambat added the PR:needs review Needs review by core team label Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR:needs review Needs review by core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT]: Reorder threads by latest interaction

3 participants