Skip to content

Simplify message presets by removing heading input #4915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timothycarambat merged 5 commits into from
Feb 9, 2026
Merged

Simplify message presets by removing heading input #4915

timothycarambat merged 5 commits into from
Feb 9, 2026
+31 −19

Conversation

@shatfield4
Copy link
Collaborator

@shatfield4 shatfield4 commented Jan 28, 2026 •
edited
Loading

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

connect #4931

  • Remove heading input from workspace settings editing form
  • New presets store empty string for heading
  • Legacy presets with headings render with semibold prefix (backward compatible)
  • Editing a legacy preset merges heading into message text
  • Chat view handles empty headings without sending a leading space

What is in this change?

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

@shatfield4 shatfield4 changed the title Remove heading input from message presets, merge legacy headings on edit Simplify message presets by removing heading input Jan 28, 2026
angelplusultra
angelplusultra reviewed Jan 29, 2026
View reviewed changes
Copy link
Contributor

@angelplusultra angelplusultra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one code refactor and some UX improvement suggestions:

  1. If I save an empty message it stays in the message array instead of filtering it out.
Image
  1. If I edit and save a message, the input bar still appears, I feel like it should go back to its non-editing state.
Image

@shatfield4 shatfield4 force-pushed the simplify-message-presets branch from 71d6ea0 to f8590d9 Compare January 30, 2026 02:00
angelplusultra
angelplusultra approved these changes Jan 30, 2026
View reviewed changes
Copy link
Contributor

@angelplusultra angelplusultra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timothycarambat timothycarambat merged commit 399613b into 4911-feat-home-page-redesign-implementation Feb 9, 2026
@timothycarambat timothycarambat deleted the simplify-message-presets branch February 9, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@angelplusultra angelplusultra angelplusultra approved these changes

@timothycarambat timothycarambat Awaiting requested review from timothycarambat

Assignees

@timothycarambat timothycarambat

Labels

PR: Zulu

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shatfield4 @angelplusultra @timothycarambat