Feature: cross validate timings

[alekseykalyagin]

Added compute_timings argument to cross_validate

Closes #138

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b3992e) to head (46e05c9).
Report is 86 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##              main      #233     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           45        59     +14     
  Lines         2242      3896   +1654     
===========================================
+ Hits          2242      3896   +1654     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blondered]

Please add new argument to docstring

[feldlime]

do we really need this param? what's wrong if we always measure the time?

[blondered]

Please update CHANGELOG.MD

[feldlime]

It seems this function accepts the label timings param but don't really need it

Let's please rewrite it in one of the following ways:

1. Remove both params and simply return the elapsed time without dictionaries
2. Rewrite it as a class

I personally prefer the second option since it's clearer.
But anyway let's not use this labels and dictionary inside. We can easily fill them out of the class

And example (it's simplified a bit, please add init if required by linters, also types)

class Timer:        
    def __enter__(self):
        self._start = time.perf_counter()
        self._end = None
        return self

    def __exit__(self, *args):
        self._end = time.perf_counter()

    @property
    def elapsed(self):
        return self._end - self._start
    
    
with Timer() as timer:
    # code
    pass

fit_time = timer.elapsed

[feldlime]

do we really need this param? what's wrong if we always measure the time?

[feldlime]

Please use time.perf_counter instead, it's more correct for measuring time intervals

[feldlime]

Please don't do this

1. If we need to format the values somehow it should always be done separately. We should separate the computing level and presentation level. From the computing level we should always return the raw values.
2. In this specific case I think we shouldn't format the value at all. I don't see much sense in it, also we're not doing this for other metrics.