Skip to content

[DOP-22425] Do not run tests as admin DB users#347

Merged
dolfinus merged 1 commit intodevelopfrom
feature/DOP-22425-prepare
Feb 21, 2025
Merged

[DOP-22425] Do not run tests as admin DB users#347
dolfinus merged 1 commit intodevelopfrom
feature/DOP-22425-prepare

Conversation

@dolfinus
Copy link
Member

@dolfinus dolfinus commented Feb 20, 2025

Change Summary

  • Replace Github Actions services: with explicit docker compose usage. This allows to use the same DB settings in both CI and local environment, without copy-pasting.
  • Add healthchecks to almost all containers (except SFTP), to ensure that containers are ready before running any tests.
  • For MongoDB and Greenplum instead of connecting to DB as owner, create a dedicated user with permissions only for test schema. This allows to catch errors then connector is trying to access tables/objects which is shouldn't. Discovered issue with MongoDB connection url format, fixed.
  • For Oracle 11.2.x tests were flaky because Oracle XE has quite small limit on process number, increased it using custom .sql file.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@codecov
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.47%. Comparing base (10e221c) to head (91e72c4).
Report is 61 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #347   +/-   ##
========================================
  Coverage    92.47%   92.47%           
========================================
  Files          228      228           
  Lines         9875     9880    +5     
  Branches      1013     1013           
========================================
+ Hits          9132     9137    +5     
  Misses         556      556           
  Partials       187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dolfinus dolfinus marked this pull request as ready for review February 20, 2025 14:11
@dolfinus dolfinus merged commit 7437eb3 into develop Feb 21, 2025
52 checks passed
@dolfinus dolfinus deleted the feature/DOP-22425-prepare branch February 21, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants