[DOP-22432] Improve CSV documentation#358
Merged
Conversation
80015c3 to
3808bcf
Compare
3808bcf to
d7ff252
Compare
d7ff252 to
a6c45de
Compare
a6c45de to
8abe178
Compare
8abe178 to
9a0bb2f
Compare
9a0bb2f to
783fe7b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #358 +/- ##
===========================================
+ Coverage 92.50% 92.54% +0.04%
===========================================
Files 229 229
Lines 10021 10079 +58
Branches 1016 1015 -1
===========================================
+ Hits 9270 9328 +58
Misses 562 562
Partials 189 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
783fe7b to
4fbe460
Compare
4fbe460 to
d300f95
Compare
d300f95 to
70b2025
Compare
IlyasDevelopment
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Previously CSV class documentation only noted that options are documented elsewhere. Now all of them are documented, included to constructor signature and can be recommended by IDE.
Almost all option values are None, and excluded from class repr.
Before:
https://onetl.readthedocs.io/en/0.13.3/file_df/file_formats/csv.html
After:
https://onetl--358.org.readthedocs.build/en/358/file_df/file_formats/csv.html
Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rstfile added describing change(see CONTRIBUTING.rst for details.)