feat: Added workflow for better Recognize/Credit Contributors #1602
feat: Added workflow for better Recognize/Credit Contributors #1602
Conversation
|
✅ Rule acceptance tests passed. |
|
✅ Rule acceptance tests passed. |
|
|
1 similar comment
|
|
|
✅ Rule acceptance tests passed. |
|
✅ Rule acceptance tests passed. |
|
✅ Rule acceptance tests passed. |
emmambd
left a comment
There was a problem hiding this comment.
@qcdyx Sorry for the wait on this! Love this idea. A few comments:
- It would be great to link to the CREDITS.md in the Contributing section of the README, so anyone looking can go see the list of everyone contributing.
- I think the Contributors section of Github has similar logic to your current PR - when a PR is merged, they're added to this graph. https://github.com/MobilityData/gtfs-validator/graphs/contributors. I'd consider modifying the logic of this action so it's providing unique insight:
- Any time a PR is merged (since that's when it impacts users)
- Any time an issue is written (this way we can shoutout contributors outside of dev contributors!)
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit d6dbf72 📊 Notices ComparisonNew Errors (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1575 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
Summary:
added a github action that writes developer contribution to credits.md
(I opt to include developer contributions in the credits.md file upon the creation of a pull request. This decision is made because certain pull requests may not be merged, yet the contributors are actively contributing to the gtfs-validator with the aim of better acknowledging their efforts.)
Expected behavior:
Testing tips:
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything