Skip to content

Fetch read length info for run instead of just lane 1#66

Merged
matrulda merged 9 commits intoMolmed:mainfrom
kjellinjonas:DATAOPS-707_fix_readlengths
May 9, 2025
Merged

Fetch read length info for run instead of just lane 1#66
matrulda merged 9 commits intoMolmed:mainfrom
kjellinjonas:DATAOPS-707_fix_readlengths

Conversation

@kjellinjonas
Copy link
Contributor

@kjellinjonas kjellinjonas commented Mar 17, 2025

Description:

Previously, get_metadata.py reported the read and index length based on the information from lane 1 which could be misleading in some cases. Therefore, it was decided that the script should be updated so that it shows the read length setting for the run instead.
In this update, this is achieved by fetching length information from RunInfo.xml

Also updated actions/cache from v2 --> v4.2.2 to enable automatic testing

Risk analysis:

The scripts will most likely fail if there are updates to the structure of the RunInfo.xml file. However, the damage from this would be minimal and should be noticed immediately.

Validation procedure:

Run ngi work flow, generate reports and makes sure that the expected read and index lengths are printed in the report.

@nkongenelly
Copy link
Contributor

Great and neat work! This looks good to me.

I would like to ask @matrulda for a second review just incase I might have missed anything i the bioinformatics side.

@nkongenelly nkongenelly requested a review from matrulda March 27, 2025 12:12
Copy link
Collaborator

@matrulda matrulda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left two suggestions for you.

@kjellinjonas kjellinjonas requested a review from matrulda March 28, 2025 14:44
Copy link
Collaborator

@matrulda matrulda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks good!

An unrelated thing that I noticed: When running the pipeline we display a version number that has not been updated in 2 years. The reason for this is that we no longer create releases for this pipeline and instead just point to commits. Since this pipeline is run through the sequencing-report-service, it became too much of a hassle to create two releases for one update.

Back to the point: until we find a way to display the commit, I think we should remove this line

printVersion()
and the function that is used.

It is out of scope for this ticket, so let me know if you rather not address it and I can make a ticket about it instead.

@kjellinjonas kjellinjonas requested a review from matrulda May 9, 2025 09:18
@kjellinjonas kjellinjonas requested a review from matrulda May 9, 2025 11:34
Copy link
Collaborator

@matrulda matrulda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@matrulda matrulda merged commit f49a23e into Molmed:main May 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants