Add symtype relations of iterables, fix for-each is valid #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Changes pass the MontiVerse
|
SE-FDr
reviewed
Feb 6, 2026
...e-grammar/src/main/java/de/monticore/statements/mccommonstatements/cocos/ForEachIsValid.java
Show resolved
Hide resolved
SE-FDr
reviewed
Feb 6, 2026
monticore-grammar/src/main/java/de/monticore/types3/SymTypeRelationsOfIterables.java
Outdated
Show resolved
Hide resolved
schmalzing
force-pushed
the
fix/for-each-is-valid-coco
branch
2 times, most recently
from
63c6ced to
001d426
Compare
schmalzing
force-pushed
the
fix/for-each-is-valid-coco
branch
from
001d426 to
8aeb5cf
Compare
SE-FDr
approved these changes
Feb 9, 2026
Contributor
SE-FDr
left a comment
SE-FDr
left a comment
There was a problem hiding this comment.
Otherwise should work disregarding very small edge cases.
| * | ||
| * @see SymTypeExpression#isArrayType() | ||
| */ | ||
| protected static boolean isOfTypeIterable(SymTypeExpression type) { |
Contributor
There was a problem hiding this comment.
Is this method needed?
Considering it is protected, why have a static version
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.