Skip to content

Fix alignment fine-tune option and alignment archive path bug #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zuazo wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix alignment fine-tune option and alignment archive path bug #930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9a8b2a
Fix restore fine-tuning behavior and add regression test
zuazo Nov 1, 2025
4ca728e
Fix: remove incorrect leading dot in .ark file construction for fine-…
zuazo Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion montreal_forced_aligner/alignment/multiprocessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,7 +957,7 @@ def _run(self):
acoustic_model=self.acoustic_model,
lexicon_compiler=self.lexicon_compilers[d.id],
)
ali_path = job.construct_path(workflow.working_directory, "ali", ".ark", d.name)
ali_path = job.construct_path(workflow.working_directory, "ali", "ark", d.name)
alignment_archive = AlignmentArchive(ali_path)
utterance_query = (
session.query(Utterance, SoundFile.sound_file_path)
Expand Down
2 changes: 1 addition & 1 deletion montreal_forced_aligner/alignment/pretrained.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def __init__(
kw.update(kwargs)
super().__init__(**kw)
self.fine_tune = fine_tune
self.fine_tune = fine_tune_boundary_tolerance
self.fine_tune_boundary_tolerance = fine_tune_boundary_tolerance
self.final_alignment = True
self.kalpy_aligner = None

Expand Down
2 changes: 2 additions & 0 deletions tests/test_commandline_align.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,8 @@ def test_align_fine_tune(
print(result.exc_info)
raise result.exception
assert not result.return_value
# Regression test for --fine_tune flag
assert "Fine tuning alignments..." in result.stderr


def test_align_evaluation(
Expand Down
Loading