Adding missing find function, fixes #564#595
Open
dotnetCarpenter wants to merge 3 commits intoMostlyAdequate:masterfrom
Open
Adding missing find function, fixes #564#595dotnetCarpenter wants to merge 3 commits intoMostlyAdequate:masterfrom
dotnetCarpenter wants to merge 3 commits intoMostlyAdequate:masterfrom
Conversation
find is referenced in chapter 8 and is needed for the IO example: // findParam :: String -> IO Maybe [String] const findParam = key => map(compose(Maybe.of, find(compose(eq(key), head)), params), url);
Contributor
Author
|
@KtorZ should I reinstate the white-spaces in appendix_c.md before this PR can be accepted? |
Member
|
@dotnetCarpenter no worries here. These are indeed extraneous. A double-whitespace marks a newline in markdown (probably should use an explicit I've been busy with other stuff lately and didn't give much time to reviews which required more than a quick eye-check. I'll allocate some time soon-ish to go through some open PRs and issues on this project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findis referenced in chapter 8 and is needed for theIOexample:This implementation of
findonly works for Array which is also the type ofparamsin the example.params :: String -> [[String]]