Conversation
…cus, and C12. Only search one side of focus based on the initial defocus.
|
@smribet Can you check my logic here for optimizing parameters based on how you usually do ptycho? |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77de16a1eb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@cjh1 Can you look at this? We want to get this running for our next experiment. It works locally on my dev machine. Also, can you pull the new container to NERSC? |
Sure, I will take a look, when is your next experiment? |
|
It will probably be in a few weeks. The scope is fairly busy until then. |
Ok, will take a look soon. |
cjh1
left a comment
cjh1
left a comment
There was a problem hiding this comment.
LGTM, once this is merged the operator image will be build by github actions.
3 participants
This adds updates to the ptycho operator which will allow more fine grained control of optimization parameters. I removed some unnecessary parameters and added some new ones. The defocus, diffraction angle, and C12 optimization can now be turned on and off with bool parameters.