Able to select samples and sort them before generating genlabIDs.#163
Able to select samples and sort them before generating genlabIDs.#163
Conversation
Has not been tested for genlabID generation.
Has not been tested for genlabID generation.
| order_by_columns = ( | ||
| [column(col, table=samples_table) for col in sorting_order] | ||
| if sorting_order | ||
| else [column("name", table=samples_table)] | ||
| ) |
There was a problem hiding this comment.
Legge til kommentarer på hva som skjer her?
There was a problem hiding this comment.
Hvorfor sorterer man i en update action?
| def update_genlab_id_query( | ||
| order_id: int | str, | ||
| sorting_order: list[str] | None = None, | ||
| selected_samples: list[Any] | None = None, | ||
| ) -> str: |
There was a problem hiding this comment.
Dette bør vi nok finne en måte å teste på før vi merger
…ready generated genlab IDs are shown for samples.
|
Generation genlab IDs have now been tested, and the code is changed as a result. In the image below, 7 samples have a generated genlabID based on their name (they are naturally sorted on species as the ID is dependent on the specie code). 
|
There was a problem hiding this comment.
Det er en drastisk endring på så viktig funksjonalitet. Hvis denne branchen ikke er avhengig av refaktoreringen hadde det kanskje vært lurt å gjøre denne endringen i en egen dedikert branch slik at det er lettere å reversere i tilfelle noe problem skulle oppstå?
There was a problem hiding this comment.
Er det skrevet tester rundt denne funksjonaliteten? Er vi sikre på at det fortsatt fungerer som forventet?
There was a problem hiding this comment.
Enig - da flytter jeg endringene i genlabid.py til en ny branch og tilpasser heller implementeringen som allerede er der.
Jeg ser ingen tester skrev rundt generering av genlabid.
There was a problem hiding this comment.
Jeg foreslår at dere kanskje setter dere sammen og prøver å skrive pytester på den funksjonen, i egen branch
| cursor.execute( | ||
| update_genlab_id_query(order_id, sorting_order, selected_samples) | ||
| ) |
There was a problem hiding this comment.
Litt usikker på om dette skal funke. cursor.execute kjører den sql-queryen den får, mens update_genlab_id_query kjører en sql query + returnerer None.
| cursor.execute( | |
| update_genlab_id_query(order_id, sorting_order, selected_samples) | |
| ) | |
| update_genlab_id_query(order_id, sorting_order, selected_samples) |
| @@ -73,7 +66,9 @@ def generate(order_id: int | str) -> None: | |||
| with connection.cursor() as cursor: | |||
| try: | |||
| with transaction.atomic(): | |||
There was a problem hiding this comment.
Tror ikke at with transaction.atomic() er nødvendig siden du dekorerer funksjonen din også med det.
4 participants
When looking at incoming samples, staff is now able to sort the columns and then generate a genlabID in their desired order. They are also able to only generate a genlabID for a selected few.
Has not been tested for genlabID generation, as I am not able to do so locally.