Skip to content

Add ruff PERF rules. #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emilte merged 1 commit into from
Jul 22, 2025
Merged

Add ruff PERF rules. #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ ignore = [
"TRY003", # This doesn't seem too bad. # https://docs.astral.sh/ruff/rules/raise-vanilla-args/
"DJ001" # Nullable string fields does is used a lot in this project. Maybe enable later? # https://docs.astral.sh/ruff/rules/django-nullable-model-string-field/
]
select = ["E", "W", "I", "F", "UP", "S", "B", "A", "COM", "LOG", "PTH", "Q", "PL", "RUF", "ANN", "PIE", "TC", "TRY", "DJ", "EM", "ISC", "RET", "SIM"]
select = ["E", "W", "I", "F", "UP", "S", "B", "A", "COM", "LOG", "PTH", "Q", "PL", "RUF", "ANN", "PIE", "TC", "TRY", "DJ", "EM", "ISC", "RET", "SIM", "PERF"]

[tool.ruff.lint.flake8-annotations]
mypy-init-return = true # https://docs.astral.sh/ruff/settings/#lint_flake8-annotations_mypy-init-return
Expand Down
2 changes: 1 addition & 1 deletion src/genlab_bestilling/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ def confirm_order(self, persist: bool = True) -> None:
for sample in self.samples.all():
try:
sample.has_error # noqa: B018
except ValidationError:
except ValidationError: # noqa: PERF203
invalid += 1

if invalid > 0:
Expand Down