Skip to content

Fix update isolation method logic #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mortenlyn merged 1 commit into from
Jul 23, 2025
Merged

Fix update isolation method logic #368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/staff/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,14 +693,10 @@ def update_isolation_methods(
name=isolation_method
).first()

try:
im = IsolationMethod.objects.filter(
name=selected_isolation_method.name
).first()
except IsolationMethod.DoesNotExist:
if selected_isolation_method is None:
messages.error(
request,
f"Isolation method '{selected_isolation_method.name}' not found.",
f"Isolation method '{isolation_method}' not found.",
)
return

Expand All @@ -709,7 +705,9 @@ def update_isolation_methods(
SampleIsolationMethod.objects.filter(sample=sample).delete()

# Add the new one
SampleIsolationMethod.objects.create(sample=sample, isolation_method=im)
SampleIsolationMethod.objects.create(
sample=sample, isolation_method=selected_isolation_method
)
messages.success(
request,
f"{samples.count()} samples updated with isolation method '{isolation_method}'.", # noqa: E501
Expand Down