Merged
Conversation
Closed
emilte
force-pushed
the
29-type-checker-for-python
branch
5 times, most recently
from
a45fee7 to
a4974fc
Compare
emilte
force-pushed
the
29-type-checker-for-python
branch
3 times, most recently
from
09d6fba to
2ce9390
Compare
Collaborator
|
I guess we can use mypy until https://github.com/astral-sh/ty is ready for production use. |
frafra
requested changes
Jun 12, 2025
Comment on lines
49
to
73
|
|
||
|
|
||
| user_redirect_view = UserRedirectView.as_view() | ||
|
|
||
|
|
||
| class UsersList(UIListView): | ||
| model = User | ||
| table_class = UserTable | ||
| filterset_class = UserFilterSet | ||
| active_dropdown = "users" | ||
| active_route = "users_list" | ||
|
|
||
|
|
||
| class UserUpdate(UIUpdateView): | ||
| model = User | ||
| fields = [ | ||
| "first_name", | ||
| "last_name", | ||
| ] | ||
| active_dropdown = "users" | ||
|
|
||
|
|
||
| class UserDetail(UIDetailView): | ||
| model = User | ||
| active_dropdown = "users" |
Collaborator
There was a problem hiding this comment.
Could you please elaborate on that? If this bit and tables.py are not needed anymore, a different commit should be made.
Contributor
Author
There was a problem hiding this comment.
I agree. I'll open another PR to suggest removal of unused code.
Contributor
Author
There was a problem hiding this comment.
I've restored the content now
Contributor
Author
There was a problem hiding this comment.
It also looks like I was mistaken. This is not dead code, it only seemed that way because of "hidden" module.
Will be fixed in #38
emilte
force-pushed
the
29-type-checker-for-python
branch
from
2ce9390 to
4dd9e6d
Compare
frafra
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.