Skip to content

Comments

Keep sorting state after page refresh #407

Merged
mortenlyn merged 2 commits intosummer25-week-30from
405-keep-sorting-state-after-page-refresh
Jul 24, 2025
Merged

Keep sorting state after page refresh #407
mortenlyn merged 2 commits intosummer25-week-30from
405-keep-sorting-state-after-page-refresh

Conversation

@mortenlyn
Copy link
Contributor

@mortenlyn mortenlyn commented Jul 24, 2025

Specifically in extraction/analysis samples pages

@mortenlyn mortenlyn self-assigned this Jul 24, 2025
@mortenlyn mortenlyn requested review from aastabk and omfj and removed request for omfj July 24, 2025 07:05
nicokant
nicokant reviewed Jul 24, 2025
View reviewed changes
Copy link
Collaborator

@nicokant nicokant left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)
I would suggest creating a Mixin (a class) that implements the logic of handling the next redirect to avoid duplicated code.

For the template you could use a component to avoid duplication as well

emilte
emilte reviewed Jul 24, 2025
View reviewed changes
@omfj omfj force-pushed the 405-keep-sorting-state-after-page-refresh branch from 529ebbc to db07921 Compare July 24, 2025 08:57
@mortenlyn mortenlyn force-pushed the 405-keep-sorting-state-after-page-refresh branch from db07921 to 529ebbc Compare July 24, 2025 09:01
@omfj omfj force-pushed the 405-keep-sorting-state-after-page-refresh branch from 529ebbc to 2b1888d Compare July 24, 2025 09:01
@mortenlyn mortenlyn force-pushed the 405-keep-sorting-state-after-page-refresh branch from 2b1888d to 8733815 Compare July 24, 2025 09:06
@mortenlyn mortenlyn force-pushed the 405-keep-sorting-state-after-page-refresh branch from 8733815 to 0510fd5 Compare July 24, 2025 09:11
@mortenlyn mortenlyn merged commit 0bb8250 into summer25-week-30 Jul 24, 2025
8 checks passed
@mortenlyn mortenlyn deleted the 405-keep-sorting-state-after-page-refresh branch July 24, 2025 09:16
emilte
emilte reviewed Jul 24, 2025
View reviewed changes
@mortenlyn mortenlyn mentioned this pull request Jul 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicokant nicokant nicokant left review comments

+3 more reviewers

@emilte emilte emilte left review comments

@omfj omfj omfj approved these changes

@aastabk aastabk aastabk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mortenlyn mortenlyn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mortenlyn @nicokant @emilte @omfj @aastabk