Merged
Conversation
emilte
reviewed
Jun 11, 2025
|
|
||
| FROM base AS production | ||
| RUN --mount=type=cache,target=/root/.cache/uv \ | ||
| uv sync --locked --group prod |
Contributor
There was a problem hiding this comment.
I suspected that this might be needed. Good catch!
I was wondering about that group, is there any benefit to having it separated? Could we just move the dependencies into the normal list?
Contributor
There was a problem hiding this comment.
If so, this step could be skipped
emilte
reviewed
Jun 11, 2025
| RUN --mount=type=cache,target=/root/.cache/uv \ | ||
| --mount=type=cache,target=/root/.cache/ms-playwright \ | ||
| uv sync --locked && \ | ||
| uv sync --locked --group dev && \ |
Contributor
There was a problem hiding this comment.
Did you experience any change with this or was it for better overview?
I believe dev is automatically included uv-regressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@emilte FYI