Conversation
Collaborator
|
actually django serves static files and media in dev, nginx is required just for production |
Collaborator
Author
|
I was a bit puzzled actually from seeing the static container only in dev :) |
Collaborator
|
Why two different containers for static and media? |
Collaborator
Author
|
Just because there were two containers already defined :) You just need one if you have a volume or a bindmount containing both folders. |
Collaborator
|
Yes, but one container is for dev and one for prod in the old code |
nicokant
reviewed
Aug 5, 2025
Collaborator
Author
Exactly as the new code :) I have not changed that, since it was out of scope. I can still do it, of course :) |
nicokant
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is how the compose file could look like with traefik.