Conversation
Test Results
Details
Github Test Reporter by CTRF 💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates PHPStan from level 5 to level 6 as the default configuration. This improves type safety and IDE autocompletion across the starter.
What Changed
@var/@param/@returnannotations throughout the codebasearray<int, T>vslist<T>mismatchesThe starter now ships at level 6 with zero errors. Levels 7 and 8 were tested during development and many issues were resolved proactively, but some remain:
Builder::where('column')string literal warnings from Larastan's model property checking, and Filament internalsauth()->user()returningUser|nullbehind auth middleware, and Filament's generic$this-recordtypeThese are framework false positives rather than real bugs. Teams targeting level 7+ should either address the remaining errors or generate a PHPStan baseline.