Improvements to the integration tests framework#401
Improvements to the integration tests framework#401mozzieongit wants to merge 51 commits intomainfrom
Conversation
This doesn't fix it actually, the |
|
Suggestion: don't tar the entire target directory, it's huge, only built binaries are actually wanted if I understand correctly. |
Good idea |
…e right container
bal-e
left a comment
There was a problem hiding this comment.
This is really cool! Making the integration tests easier to run would be awesome.
Have you had a chance to test whether this will now work under GitHub Actions? IIRC it hasn't worked thus far.
It will work even less under GitHub Actions. The container use different users. If that is something we think we should have, I'd make a separate PR. But I would be fine with local only running of integration tests. |
I see. My only concern is that it's easy to forget to run the integration tests; but regardless, your work here is making them easier to use, and that's great. We can continue examining this issue in the future. |
We could add a note to a PR template |
actimage (and an accompanying wrapper script) to reduce image size, build time, and test run time.cascade{,d}/dnst) to PATH for easier useConsider:
.testand provide a script to update the DS RR forexample.test? (I had used bind9 for it's DNS UPDATE capability)Provide more errors in the test env management script when components fail (so lots of(obsolete with logging every command run using|| { echo "bla"; exit 11; }; to make spotting failing components easier)set -x)