Skip to content

Conversation

@JiliDong-NOAA
Copy link
Contributor

DESCRIPTION OF CHANGES:

  • This PR updates the executable names to meet NCO EE2 requirements by matching them to top level of sorc. The executable names in related scripts are also modified for consistency.

The compiling is successful after the changes to app_build.sh but the full workflow has not been fully tested.

TESTS CONDUCTED:

Machines/Platforms:

  • WCOSS2
    • Cactus/Dogwood
    • Acorn
  • RDHPCS
    • Hera
    • Jet
    • Orion
    • Hercules

Test cases:

  • Engineering tests
    • Non-DA engineering test
    • DA engineering test
      • Retro
      • Ensemble
      • Parallel
  • RRFS fire weather
  • RRFS_A:
  • RRFS_B:
  • RTMA:
  • Others:

ISSUE:

CONTRIBUTORS (optional):

@JiliDong-NOAA
Copy link
Contributor Author

These are executables I could not find in any of the scripts/, ush/, or job/ directories, but I may have missed them elsewhere.

aqm_util_gefs2lbc_para
rrfs_util_check_imssnow_fv3lam.exe
rrfs_util_fv3lam_pre_blending_tq.exe
rrfs_util_fv3lam_pre_blending_uv.exe
rrfs_util_gen_annual_maxmin_gvf.exe
rrfs_util_gen_cs.exe
rrfs_util_gen_ensmean_recenter.exe
rrfs_util_lakesurgery.exe
rrfs_util_process_pm.exe
rrfs_util_ref2tten.exe
rrfs_util_rrfs_bucket.exe
rrfs_util_rrfs_maxrh.exe
rrfs_util_rrfs_maxt.exe
rrfs_util_rrfs_minrh.exe
rrfs_util_rrfs_mint.exe
ufs_util_fregrid
ufs_util_inland
ufs_util_lakefrac
ufs_util_ocean_merge

@JamesPolly-NCO
Copy link
Collaborator

Thank you for this @JiliDong-NOAA. So I do not have to pull this branch and build everything, would it possible for you to list the contents of the executable directory that would be associated with this PR?

@JiliDong-NOAA
Copy link
Contributor Author

Thank you for this @JiliDong-NOAA. So I do not have to pull this branch and build everything, would it possible for you to list the contents of the executable directory that would be associated with this PR?

Sure. The exec directory has:

aqm_util_gefs2lbc_para                 rrfs_util_process_metarcld.exe     rrfs_util_update_ice.exe
gsi_enkf.x                             rrfs_util_process_NSSL_mosaic.exe  rrfs_util_use_raphrrr_sfc.exe
gsi.x                                  rrfs_util_process_pm.exe           ufs_model
rrfs_util_adjust_soiltq.exe            rrfs_util_process_updatesst.exe    ufs_util_chgres_cube
rrfs_util_check_imssnow_fv3lam.exe     rrfs_util_radmon_angle.x           ufs_util_filter_topo
rrfs_util_dpt2m_post.exe               rrfs_util_radmon_bcoef.x           ufs_util_fregrid
rrfs_util_ens_mean_recenter_P2DIO.exe  rrfs_util_radmon_bcor.x            ufs_util_fvcom_to_FV3
rrfs_util_firewx_gridspecs.exe         rrfs_util_radmon_time.x            ufs_util_global_equiv_resol
rrfs_util_fv3lam_nonvarcldana.exe      rrfs_util_ref2tten.exe             ufs_util_inland
rrfs_util_fv3lam_pre_blending.exe      rrfs_util_rrfs_bucket.exe          ufs_util_lakefrac
rrfs_util_fv3lam_pre_blending_tq.exe   rrfs_util_rrfs_bufr.exe            ufs_util_make_hgrid
rrfs_util_fv3lam_pre_blending_uv.exe   rrfs_util_rrfs_maxrh.exe           ufs_util_make_solo_mosaic
rrfs_util_gen_annual_maxmin_GVF.exe    rrfs_util_rrfs_maxt.exe            ufs_util_ocean_merge
rrfs_util_gen_cs.exe                   rrfs_util_rrfs_minrh.exe           ufs_util_orog
rrfs_util_gen_ensmean_recenter.exe     rrfs_util_rrfs_mint.exe            ufs_util_orog_gsl
rrfs_util_lakesurgery.exe              rrfs_util_rrfs_sndp.exe            ufs_util_regional_esg_grid
rrfs_util_process_imssnow_fv3lam.exe   rrfs_util_rrfs_stnmlist.exe        ufs_util_sfc_climo_gen
rrfs_util_process_larccld.exe          rrfs_util_update_bc.exe            ufs_util_shave
rrfs_util_process_Lightning.exe        rrfs_util_update_GVF.exe           upp.x

Copy link
Collaborator

@JamesPolly-NCO JamesPolly-NCO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new executable names match up with sorc subdirectories as requested. Thank you for doing this @JiliDong-NOAA 👍

@MatthewPyle-NOAA
Copy link
Contributor

@ShunLiu-NOAA

Are these executables used with the latest blending code?

rrfs_util_fv3lam_pre_blending_tq.exe
rrfs_util_fv3lam_pre_blending_uv.exe

@ShunLiu-NOAA
Copy link
Contributor

@ShunLiu-NOAA

Are these executables used with the latest blending code?

rrfs_util_fv3lam_pre_blending_tq.exe rrfs_util_fv3lam_pre_blending_uv.exe

I tracked the hash history of rrfs_util. The current hash includes the updates from my PR #1189. Therefore, these executables contain the latest blending code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants