NGWPC NWM PI-3 Formulation Selection Delivery 2025-11-21#18
Open
cmaynard-ngwpc wants to merge 88 commits intoNOAA-OWP:masterfrom
Open
NGWPC NWM PI-3 Formulation Selection Delivery 2025-11-21#18cmaynard-ngwpc wants to merge 88 commits intoNOAA-OWP:masterfrom
cmaynard-ngwpc wants to merge 88 commits intoNOAA-OWP:masterfrom
Conversation
Ngwpc 2349 mkarim See merge request NGWPC/nwm-ngen/sac-sma!2
NGWPC-3711: Bug Fix See merge request NGWPC/nwm-ngen/sac-sma!3
fixed sac TCI unit issue See merge request NGWPC/nwm-ngen/sac-sma!4
rc-master: Release 1.0.0 Merge See merge request NGWPC/nwm-ngen/sac-sma!6
Adding Logging See merge request NGWPC/nwm-ngen/sac-sma!5
…ent' Fix cmake for logging and datetime libs See merge request NGWPC/nwm-ngen/sac-sma!7
Sac snow17 update See merge request NGWPC/nwm-ngen/sac-sma!8
Text file containing repository version number and date See merge request NGWPC/nwm-ngen/sac-sma!9
Revert "Merge branch 'cmaynard_NGWPC-4611_version_file' into 'development'" See merge request NGWPC/nwm-ngen/sac-sma!10
…ment' Text file containing repository version number, date and commit hash See merge request NGWPC/nwm-ngen/sac-sma!12
Development Branch Merge to release-candidate branch for Release rc-1.1.0 See merge request NGWPC/nwm-ngen/sac-sma!14
…didate' Update version file for Release rc-1.1.0 See merge request NGWPC/nwm-ngen/sac-sma!16
reduce mass balance warning messages See merge request NGWPC/nwm-ngen/sac-sma!17
…ndidate' Update version file for release rc-1.1.0A See merge request NGWPC/nwm-ngen/sac-sma!18
Release candidate rc-1.1.0A merge to development See merge request NGWPC/nwm-ngen/sac-sma!19
Release Candidate Branch Merge to main for Release 1.1.0 See merge request NGWPC/nwm-ngen/sac-sma!20
…sion Fix logger recursion (NGWPC-8295)
… requires a few more updates to wire with the BMI correctly.
…e with deserialization.
… before creating a MR.
…ER(4 to INTEGER(1) before unpacking
…erialization routines to reflect new format.
Serialization routines and libraries (NGWPC-7765)
|
Our team’s assessment of this PR is that it requires further revisions and should not be approved or merged in its current form. The primary reasons are problems with the build config on different compilers and systems, questions about how the changes properly handle mass imbalance, and issues related to the added serialization functionality code. For more details, see the related NWM QA issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement and refine initial serialization and deserialization routines for state saving, including support for new state variables (itime, time_dbl), temporary byte buffers, 64-bit integer handling, and per-HRU deserialization. Logging was improved with hierarchical log levels, removal of redundant stdout prints, and updated logger usage for standalone runs. Several commits address code formatting, Makefile touchups, whitespace cleanup, and compiler compatibility. Documentation was updated to reflect logger usage, version.txt was deleted, and the license file was revised for OWP government requirements. Merges from GitHub master were incorporated, and snow17 parameter-saving issues were fixed.