Add VSC Two Terminal Loss Model #1167
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigomha
changed the title
Contributor
Author
|
@jd-lara This PR is ready for review. Tests are passing locally with these branches that also need merge:
|
This was
linked to
issues
Dec 24, 2024
Member
|
Requires PSY 5.0 |
Member
|
@rodrigomha I changed the target to a new branch and merged psy5 onto this PR |
Closed
jd-lara
reviewed
Mar 19, 2025
Member
jd-lara
left a comment
jd-lara
left a comment
There was a problem hiding this comment.
@rodrigomha I need to make a review to the model before we merge
Member
|
@rodrigomha there are pretty bad merges in the branch_constructor.jl file that need to be merged correctly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close: #1200 #1199 #1198 #1197