refactor(llmrails)!: remove deprecated return_context argument#1147
Merged
refactor(llmrails)!: remove deprecated return_context argument#1147
Conversation
Pouyanpi
force-pushed
the
refactor/remove-deprecated-return-context
branch
from
f76738c to
bbdd4a5
Compare
Pouyanpi
changed the title
Pouyanpi
added
bug
cparisien
reviewed
May 1, 2025
cparisien
approved these changes
May 1, 2025
The `return_context` argument has been removed from the LLMRails class methods as it was deprecated. Users are encouraged to use `GenerationOptions.output_vars = True` instead. This change simplifies the interface and eliminates deprecated functionality. BREAKING CHANGE: The `return_context` argument is no longer supported.
Pouyanpi
force-pushed
the
refactor/remove-deprecated-return-context
branch
from
bbdd4a5 to
5de0ae5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1147 +/- ##
===========================================
+ Coverage 68.00% 68.02% +0.01%
===========================================
Files 161 161
Lines 15793 15786 -7
===========================================
- Hits 10740 10738 -2
+ Misses 5053 5048 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trebedea
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
return_contextargument has been removed from the LLMRails class methods as it was deprecated. Users are encouraged to useGenerationOptions.output_vars = Trueinstead. This change simplifies the interface and eliminates deprecated functionality.BREAKING CHANGE: The
return_contextargument is no longer supported.