Skip to content

Conversation

@XuesongYang
Copy link
Collaborator

@XuesongYang XuesongYang commented Feb 2, 2026

Summary

Details

  • Added logging support when running validation on multiple datasets. the training configuration looks like below,
python examples/tts/magpietts.py \\
    ...
    model.train_ds.input_cfg="/data/magpie_pretraining_data/manifests/train_input_cfg_audioCodec21fpsCausalDecoder_en.yaml" \\
    ...
    model.validation_ds.datasets="/xueyang_data/val_input_cfg_audioCodec21fpsCausalDecoder_en.yaml" \\
    ...

where, the yaml config for validation datasets looks like below, which is apt to generalize to multiple languages datasets.

$ cat /xueyang_data/val_input_cfg_audioCodec21fpsCausalDecoder_en.yaml
- name: "LibriTTS_dev_clean"
  input_cfg: "/data/magpie_pretraining_data/manifests/val_input_cfg_audioCodec21fpsCausalDecoder_en.yaml"
- name: "LibriTTS_test_clean"
  input_cfg: "/xueyang_data/val_input_cfg_audioCodec21fpsCausalDecoder_en_LibriTTS_testClean.yaml"
  • example plots from wandb:
Screenshot 2026-02-02 at 4 26 33 PM Screenshot 2026-02-02 at 4 27 07 PM Screenshot 2026-02-02 at 4 27 30 PM Screenshot 2026-02-02 at 4 27 52 PM

@XuesongYang XuesongYang force-pushed the xueyang/pr-multi-val-dataloaders-main branch from 861e8b3 to fae5fcb Compare February 2, 2026 22:08
@XuesongYang XuesongYang marked this pull request as ready for review February 3, 2026 00:31
XuesongYang and others added 3 commits February 2, 2026 17:35
…VIDIA-NeMo#15189)

* added multiple validation dataloaders and log metrics per val data.

* Apply suggestion from @XuesongYang

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>

* Apply suggestion from @Copilot

    Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>

* Apply suggestion from @Copilot

    Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>

* Apply suggestion from @Copilot

    Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>

---------

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
Co-authored-by: Xuesong Yang <16880-xueyang@users.noreply.gitlab-master.nvidia.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ation to on_validation_epoch_end.

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
@XuesongYang XuesongYang force-pushed the xueyang/pr-multi-val-dataloaders-main branch from fae5fcb to c9cc855 Compare February 3, 2026 01:35
Copilot AI review requested due to automatic review settings February 3, 2026 01:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for validating MagpieTTS on multiple datasets (multiple validation dataloaders) while improving how media artifacts (audio + attention visualizations) are prepared and logged to W&B/TensorBoard, and updates the example Lhotse config to the new dataset configuration structure.

Changes:

  • Refactors validation media logging by separating data preparation (numpy arrays) from logger-specific emission (W&B/TB objects).
  • Adds multi-dataloader validation support, including per-dataloader metric aggregation and an averaged validation loss for checkpointing.
  • Updates the MagpieTTS Lhotse example config to remove the dataset: nesting and introduce a validation_ds.datasets list format.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
nemo/collections/tts/models/magpietts.py Implements multi-validation-dataloader handling, refactors media logging, and adjusts Lhotse dataloader config expectations.
examples/tts/conf/magpietts/magpietts_lhotse.yaml Updates example configuration to match the new train/validation dataset config structure and multi-val datasets list format.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
…exists in val ds config

Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
@XuesongYang XuesongYang disabled auto-merge February 4, 2026 00:37
Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants