Fail early if output engine file path is unwritable in trtexec#4449
Fail early if output engine file path is unwritable in trtexec#4449PierreMarieCurie wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
|
/blossom-ci |
|
/blossom-ci |
1 similar comment
|
/blossom-ci |
|
Hello @PierreMarieCurie thanks for your contribution! Can you target the main branch and have your commits rebase on that? |
7010618 to
0cd927d
Compare
|
Hello @poweiw, thanks for your feedback. I've rebased my branch onto main and updated the PR to target it. Let me know if there's anything else you'd like adjusted. |
|
Thanks Pierre for the fast response! I lost my permission to trigger the pipeline but should be able to run next week. Will lyk with the pipeline results. |
|
/blossom-ci |
74de927 to
0392688
Compare
|
Hello @poweiw and @kevinch-nv, I messed up my rebase, sorry about that. The target branch was correct, but it was based on an old commit, so the pipeline failed. It should be fixed now. |
|
/blossom-ci |
|
Hello, any update on this MR when you get a chance? Thanks a lot! |
…X parsing Signed-off-by: Paul Pacheco <154653205+PierreMarieCurie@users.noreply.github.com>
0392688 to
ad2ea5f
Compare
|
/blossom-ci |
Hi NVIDIA team,
This PR adds an early check in trtexec to ensure the --saveEngine path is writable before starting ONNX parsing. It avoids unnecessary compute when the path is invalid. This a proposition to solve issue #4448.
It has only been tested on the following environment: Ubuntu 24.04 running as a Dev Container within WSL2.
Thanks!