Open
Conversation
miscco
force-pushed
the
pointer_traits_address_of
branch
from
c7fab2a to
0403ea8
Compare
davebayer
reviewed
Jan 30, 2026
|
|
||
| THRUST_NAMESPACE_END | ||
|
|
||
| _CCCL_BEGIN_NAMESPACE_CUDA_STD |
Contributor
There was a problem hiding this comment.
This namespace shoulnd't be used outside of libcu++, we've already have some problems using it in cub
bernhardmgruber
approved these changes
Jan 30, 2026
Contributor
bernhardmgruber
left a comment
bernhardmgruber
left a comment
There was a problem hiding this comment.
LGTM, just some questions.
Comment on lines
+504
to
+505
| // Backwards compatability with thrust::detail::pointer_traits | ||
| using raw_pointer = typename pointer::raw_pointer; |
Contributor
There was a problem hiding this comment.
Q: This is only used internally, right? So we can eventually remove this, right?
Comment on lines
+522
to
+526
| //! For backwards compatability with old pointer traits | ||
| [[nodiscard]] _CCCL_API static constexpr raw_pointer get(const pointer iter) noexcept | ||
| { | ||
| return iter.get(); | ||
| } |
Contributor
There was a problem hiding this comment.
Why can't we replace all occurrences by to_address?
Contributor
😬 CI Workflow Results🟥 Finished in 3h 43m: Pass: 97%/146 | Total: 6d 19h | Max: 3h 43m | Hits: 45%/350009See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This publicate a lot of logic.
Its a bit unfortunate, some of the logic is non standard conforming, so I was not yet able to replate all of it