Skip to content

reporting: have qual_review support report.jsonl eval entries from 0.13.3 and earlier#1605

Merged
jmartin-tech merged 1 commit intoNVIDIA:mainfrom
leondz:reporting/qual_review_total_backcompat
Feb 4, 2026
Merged

reporting: have qual_review support report.jsonl eval entries from 0.13.3 and earlier#1605
jmartin-tech merged 1 commit intoNVIDIA:mainfrom
leondz:reporting/qual_review_total_backcompat

Conversation

@leondz
Copy link
Collaborator

@leondz leondz commented Feb 4, 2026

The eval entries in report.jsonl were updated in 0.14.0.pre1 to remove the total entry and add total_processed and total_evaluated.

qual_review relies on these totals to make assessments, but is often used with garak report.jsonl files from earlier versions

This PR enables the previous format and assumes total is total_evaluated

Testing

  • run garak.analyze.qual_review on a report from the current version of garak without KeyErrors
  • run garak.analyze.qual_review on a report from garak 0.13.3 or earlier without KeyErrors

@leondz leondz added the reporting Reporting, analysis, and other per-run result functions label Feb 4, 2026
@jmartin-tech jmartin-tech self-assigned this Feb 4, 2026
Copy link
Collaborator

@jmartin-tech jmartin-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmartin-tech jmartin-tech merged commit 11c7e1f into NVIDIA:main Feb 4, 2026
16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

reporting Reporting, analysis, and other per-run result functions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants