Add braces to resolve c2360 - VS2026 compatibility #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build_common.ps1
Outdated
| # Get path to Visual Studio installation using vswhere. | ||
| # | ||
| $vsPath = &$vsWhere -latest -version "[16.0,18.0)" -products * ` | ||
| $vsPath = &$vsWhere -latest -products * ` |
Collaborator
There was a problem hiding this comment.
Completely removing the version check is probably a bad idea - could cause problems for people with older VS versions installed. Should this just be -version "[16.0,19.0)" instead?
Contributor
Author
There was a problem hiding this comment.
I've put this in :)
Collaborator
|
Please squash your commits. |
When building DXVK Remix with MSVC 19.x (VS 2026), the compiler emits C2360 / C2361 warnings because a local variable is declared directly after a case label. With /WX enabled these become errors and the build aborts.
Added {} around every case …: block that declares workgroups. This makes the declaration part of a proper block scope, satisfying the C++ rule that control flow cannot jump over an initialization. The change is purely syntactic.
Expanded the version check from build_common.ps1.
Builds now succeed on VS 2026.
No functional / logic / shader changes.
Updated build_common.ps1 to expand the Visual Studio version check.
The version check allows VS '26 but still checks that the user has at least VS '19 to avoid problems for people with older VS versions installed.
BinqAdams
force-pushed
the
refactor/c2360-workgroup-braces
branch
from
b1d6f64 to
8c65bfd
Compare
Contributor
Author
Squashed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building DXVK Remix with MSVC 19.x (VS 2026), the compiler emits C2360 / C2361 warnings because a local variable is declared directly after a case label. With /WX enabled these become errors and the build aborts.
Added {} around every case …: block that declares workgroups. This makes the declaration part of a proper block scope, satisfying the C++ rule that control flow cannot jump over an initialization. The change is purely syntactic.
Expanded the version check from build_common.ps1.
Builds now succeed on VS 2026.
No functional / logic / shader changes.