Open
Conversation
visualize target & draw body collision spheres
BaseFabric-load_robot(): move enabled joint check from all_non_fixed_joints -> self.joints_meta
Read joint upper/lower limit from Newton model, instead of Model Builder
… joint_qd_start BaseFabric.load_robot(): simplify joints_meta composing
|
@Tadinu Thanks for mentioning me ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @kavanwyk,
Thank you very much for this amazing repo for the community, the first afaik on using Warp for batched Fabrics!
Earlier, we used to only have https://github.com/tud-amr/fabrics, a great one by @maxspahn.
This PR mostly is only for reference regarding:
Notes:
pyproject.toml, setup.py, deps.txt: removeurdfpyREADME.md: update installation steps by replacing one forurdfpywithnewtonfabric.py:FabricJointMetadata class, hosting joint info: name, type, upper/lower limitBaseFabric: removeurdfpy_robot,joint_names->joints_meta,_num_joints-> propertynum_joints: len(self.joints_meta)load_robot(): usenewton.ModelBuilderinstead ofwp.sim.ModelBuilder, loading joints meta directly from the former.-> Keep
newton.ModelBuilderas class member for more conveniently later browsing, as the compiledmodelpossibly resides in GPU.import_urdf.py - parse_urdf_annotated():newton.parse_urdf(), removing supporting utils likeKinematicTree, expand_link()for the old loading function.UrdfInfo(Most important changes)kinematics.py:wp.sim->newton.JointTypeKinematicsBase init:wp.sim.ModelBuilder->newton.ModelBuilderworld_mesh_model.py - create_object_model():wp.sim.ModelBuilder->newton.ModelBuilder