NYPL core objects async refactor#429
Merged
charmingduchess merged 10 commits intomainfrom Dec 20, 2024
Merged
Conversation
nonword
reviewed
Dec 19, 2024
Member
nonword
left a comment
There was a problem hiding this comment.
Looks right, but don't see the package*.json updates
Contributor
Author
|
original failed tests are from before i had pushed the new tag up for nypl-core. |
nonword
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update D API to use new v3 nypl core objects which is async.
load_nypl_corewhich prefetches the nypl core data inapp.js