Skip to content

NYPL core objects async refactor#429

Merged
charmingduchess merged 10 commits intomainfrom
noref-nypl-core-objects-async
Dec 20, 2024
Merged

NYPL core objects async refactor#429
charmingduchess merged 10 commits intomainfrom
noref-nypl-core-objects-async

Conversation

@charmingduchess
Copy link
Contributor

Update D API to use new v3 nypl core objects which is async.

  • add load_nypl_core which prefetches the nypl core data in app.js
  • export the values that are preloaded, with an empty object default to avoid reference errors in the case of something going awry.
  • update all references to nypl core mappings to use new syntax
  • update a test to use before for const declarations

Copy link
Member

@nonword nonword left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right, but don't see the package*.json updates

@charmingduchess charmingduchess marked this pull request as ready for review December 19, 2024 18:58
@charmingduchess
Copy link
Contributor Author

original failed tests are from before i had pushed the new tag up for nypl-core.

@charmingduchess charmingduchess merged commit c257110 into main Dec 20, 2024
4 checks passed
charmingduchess added a commit that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments