Skip to content

update build spec requestable#430

Merged
charmingduchess merged 16 commits intonoref-nypl-core-objects-asyncfrom
SCC-4286/update-spec-requestable
Dec 20, 2024
Merged

update build spec requestable#430
charmingduchess merged 16 commits intonoref-nypl-core-objects-asyncfrom
SCC-4286/update-spec-requestable

Conversation

@charmingduchess
Copy link
Contributor

@charmingduchess charmingduchess commented Dec 19, 2024

  • expand specRequestable criteria to include finding aids and locations with collectionAccessType === "special"
  • write tests
  • add override so spec requestable items are never physically requestable

Copy link
Member

@nonword nonword left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right

app.js Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@charmingduchess charmingduchess merged commit dfa867e into noref-nypl-core-objects-async Dec 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments