Change the multipart lib to improve performances#2409
Change the multipart lib to improve performances#2409ClemPi wants to merge 1 commit intoNancyFx:masterfrom ClemPi:multipart
Conversation
|
Hi, Nice! This is one of those things that you just don't pull in without giving it a proper code review and step the code a bit. Even then it's a nightmare to dare to pull the merge button because of the uncertainty of that scenarios that might be broken :D So before we start reviewing that, there are some pretty big code style violations that would need to be fixed. I would prefer if they were addressed before we even started looking at the actual implementation logic. You can find the style guides here (they were also linked during the pull-request process) Thanks |
|
I'm aware that the code added in HttpMultipart directory is not coding style compliant. Regards |
|
Rather than directly pull in the codebase, can we learn from it and apply changes to the existing handling? |
Related to #2355 I reworked the Multipart handling and used https://github.com/Vodurden/Http-Multipart-Data-Parser to do so.
Here are some performances test I made:
Please let me know if this look OK for you before I start working on the tests. I included all the lib, maybe we want to only pick relevant classes.
Regards