Skip to content

Fix ElectricPanel negative HeadroomSpaces, take 2#2108

Merged
shorowit merged 6 commits intonot_presentfrom
panel-spaces-fix2
Dec 24, 2025
Merged

Fix ElectricPanel negative HeadroomSpaces, take 2#2108
shorowit merged 6 commits intonot_presentfrom
panel-spaces-fix2

Conversation

@shorowit
Copy link
Contributor

@shorowit shorowit commented Dec 2, 2025

Pull Request Description

Follow-up to #2101. Makes use of proposed change in hpxmlwg/hpxml#456. Adds a new output: Electric Panel Load: Max Current Rating (A).

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.sch) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit moved this from Triage to In progress in OpenStudio-HPXML Dec 9, 2025
@shorowit shorowit added the hpxml label Dec 19, 2025
@shorowit shorowit added this to the 1.11.0 milestone Dec 19, 2025
…o panel-spaces-fix2

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
#	HPXMLtoOpenStudio/tests/test_electric_panel.rb
@shorowit shorowit marked this pull request as ready for review December 23, 2025 20:29
@shorowit shorowit changed the base branch from master to not_present December 24, 2025 01:22
…into panel-spaces-fix2

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
@shorowit
Copy link
Contributor Author

Other HPXML v5-based PRs need this to avoid CI failures so I'm going to merge this in. If any other changes are needed, we can do it in another PR.

@shorowit shorowit merged commit ba4decc into not_present Dec 24, 2025
1 of 4 checks passed
@shorowit shorowit deleted the panel-spaces-fix2 branch December 24, 2025 01:24
@github-project-automation github-project-automation bot moved this from In progress to Done in OpenStudio-HPXML Dec 24, 2025

Headroom is calculated as the panel's maximum current rating minus calculated capacity.
A positive value indicates panel availability whereas a negative value indicates panel constraint.
.. [#] Headroom Capacity is the Max Current Rating minus the calculated NEC Total Capacity.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants