Fix ElectricPanel negative HeadroomSpaces, take 2#2108
Merged
shorowit merged 6 commits intonot_presentfrom Dec 24, 2025
Merged
Conversation
…o panel-spaces-fix2 # Conflicts: # HPXMLtoOpenStudio/measure.xml # HPXMLtoOpenStudio/tests/test_electric_panel.rb
…into panel-spaces-fix2 # Conflicts: # HPXMLtoOpenStudio/measure.xml
Contributor
Author
|
Other HPXML v5-based PRs need this to avoid CI failures so I'm going to merge this in. If any other changes are needed, we can do it in another PR. |
|
|
||
| Headroom is calculated as the panel's maximum current rating minus calculated capacity. | ||
| A positive value indicates panel availability whereas a negative value indicates panel constraint. | ||
| .. [#] Headroom Capacity is the Max Current Rating minus the calculated NEC Total Capacity. |
46 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Follow-up to #2101. Makes use of proposed change in hpxmlwg/hpxml#456. Adds a new output:
Electric Panel Load: Max Current Rating (A).Checklist
Not all may apply:
EPvalidator.sch) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run