Skip to content

BuildResidentialHPXML: Exclude siding from interzonal walls assembly R-value#2121

Merged
shorowit merged 2 commits intomasterfrom
fix_interzonal_grg_wall_siding
Dec 12, 2025
Merged

BuildResidentialHPXML: Exclude siding from interzonal walls assembly R-value#2121
shorowit merged 2 commits intomasterfrom
fix_interzonal_grg_wall_siding

Conversation

@shorowit
Copy link
Contributor

@shorowit shorowit commented Dec 12, 2025

Pull Request Description

Closes #2120. Exclude siding from assembly R-value for interzonal walls (e.g., wall between conditioned space and garage). And some misc code cleanup.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.sch) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit marked this pull request as ready for review December 12, 2025 17:59
@shorowit shorowit merged commit 22dbf37 into master Dec 12, 2025
@shorowit shorowit deleted the fix_interzonal_grg_wall_siding branch December 12, 2025 17:59
@github-project-automation github-project-automation bot moved this from Triage to Done in OpenStudio-HPXML Dec 12, 2025
@shorowit shorowit added the bug label Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Interzonal walls include siding R-value

1 participant