Skip to content

Use <BuildingID> instead of UnitX in whole-building timeseries outputs #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shorowit merged 11 commits into from
Jan 21, 2026
Merged

Use <BuildingID> instead of UnitX in whole-building timeseries outputs #2146

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
200cd26
Bit of refactoring so we can report <BuildingID> instead of Unit1, et…
joseph-robertson Jan 16, 2026
496fdfe
Update whole-building timeseries unit test.
joseph-robertson Jan 16, 2026
6615fbb
Simplify the sanitize_name method.
joseph-robertson Jan 16, 2026
254db4a
Simplify further.
joseph-robertson Jan 16, 2026
0b195ed
Code cleanup, comments.
joseph-robertson Jan 20, 2026
a17b7bb
Merge branch 'master' into whole-bldg-timeseries-outputs
joseph-robertson Jan 20, 2026
1927ba9
Revert all refactor changes for passing hpxml parent object.
joseph-robertson Jan 21, 2026
2e44100
Clean up sanitize_name method.
joseph-robertson Jan 21, 2026
97cd89b
Update the changelog.
joseph-robertson Jan 21, 2026
526ce9e
Minor cleanup.
shorowit Jan 21, 2026
e05104f
Typo [ci skip]
shorowit Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions HPXMLtoOpenStudio/measure.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,20 +343,20 @@ def create_unit_model(hpxml, hpxml_bldg, runner, model, weather, schedules_file)

# Conditioned space & setpoints
spaces = {} # Map of HPXML locations => OpenStudio Space objects
Geometry.create_or_get_space(model, spaces, HPXML::LocationConditionedSpace, hpxml_bldg)
Geometry.create_or_get_space(model, spaces, HPXML::LocationConditionedSpace, hpxml, hpxml_bldg)
hvac_days = HVAC.apply_setpoints(runner, model, weather, spaces, hpxml_bldg, hpxml.header, schedules_file)

# Geometry & Enclosure
Geometry.apply_foundation_and_walls_top(hpxml_bldg, hpxml.header)
Geometry.apply_roofs(runner, model, spaces, hpxml_bldg, hpxml.header)
Geometry.apply_walls(runner, model, spaces, hpxml_bldg, hpxml.header)
Geometry.apply_rim_joists(runner, model, spaces, hpxml_bldg, hpxml.header)
Geometry.apply_floors(runner, model, spaces, hpxml_bldg, hpxml.header)
Geometry.apply_foundation_walls_slabs(runner, model, spaces, weather, hpxml_bldg, hpxml.header, schedules_file)
Geometry.apply_windows(runner, model, spaces, hpxml_bldg, hpxml.header)
Geometry.apply_doors(model, spaces, hpxml_bldg, hpxml.header)
Geometry.apply_skylights(runner, model, spaces, hpxml_bldg, hpxml.header)
Geometry.apply_conditioned_floor_area(model, spaces, hpxml_bldg)
Geometry.apply_roofs(runner, model, spaces, hpxml, hpxml_bldg)
Geometry.apply_walls(runner, model, spaces, hpxml, hpxml_bldg)
Geometry.apply_rim_joists(runner, model, spaces, hpxml, hpxml_bldg)
Geometry.apply_floors(runner, model, spaces, hpxml, hpxml_bldg)
Geometry.apply_foundation_walls_slabs(runner, model, spaces, weather, hpxml, hpxml_bldg, schedules_file)
Geometry.apply_windows(runner, model, spaces, hpxml, hpxml_bldg)
Geometry.apply_doors(model, spaces, hpxml, hpxml_bldg)
Geometry.apply_skylights(runner, model, spaces, hpxml, hpxml_bldg)
Geometry.apply_conditioned_floor_area(model, spaces, hpxml, hpxml_bldg)
Geometry.apply_thermal_mass(model, spaces, hpxml_bldg, hpxml.header)
Geometry.set_zone_volumes(spaces, hpxml_bldg, hpxml.header)
Geometry.explode_surfaces(model, hpxml_bldg)
Expand Down
8 changes: 4 additions & 4 deletions HPXMLtoOpenStudio/measure.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>hpxm_lto_openstudio</name>
<uid>b1543b30-9465-45ff-ba04-1d1f85e763bc</uid>
<version_id>da8d965b-0724-4490-b122-9d66b3542626</version_id>
<version_modified>2026-01-12T21:15:28Z</version_modified>
<version_id>82f64611-a8f7-4396-b7ee-a3647cbf4829</version_id>
<version_modified>2026-01-16T20:25:30Z</version_modified>
<xml_checksum>D8922A73</xml_checksum>
<class_name>HPXMLtoOpenStudio</class_name>
<display_name>HPXML to OpenStudio Translator</display_name>
Expand Down Expand Up @@ -192,7 +192,7 @@
<filename>measure.rb</filename>
<filetype>rb</filetype>
<usage_type>script</usage_type>
<checksum>4FAA1035</checksum>
<checksum>D14D8956</checksum>
</file>
<file>
<filename>airflow.rb</filename>
Expand Down Expand Up @@ -372,7 +372,7 @@
<filename>geometry.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>5EA7867A</checksum>
<checksum>F3B9FF0E</checksum>
</file>
<file>
<filename>hotwater_appliances.rb</filename>
Expand Down
Loading
Loading