Force 'cell' datasets in DqdvFitter to have 'Ah' column #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new
DqdvFitterand downstreamcalc_lam_lliandplot_lam_llifunctions required information about the full-cell maximum capacity. This was always planned to add, but was not done during the original overhaul of thedqdvmodule. Thus, without expert knowledge of the code it was challenging to use. Now, checks require thecelldata of the fitter to always have anAhcolumn. This allows the fitter to store the max capacity and pass it along through fit results/tables, etc.The
DqdvFitterclass also now provides a check to make sure the datasets are correctly oriented. That is, as SOC increases, the voltage decreases in the negative-electrode dataset, and increases in the positve-electrode and full-cell datasets. This reduces added stress on the user to guarantee this convention.Type of change
Key checklist:
$ nox -s linter [-- format]$ nox -s codespell [-- write]$ nox -s tests$ nox -s badgesFurther checks:
$ nox -s docs.