Add Query Subplans to Metrics [Query Metric Service] #2849
Conversation
|
It will help to add a few Subplans in populateMetric in QueryMetricTestBase (and erase them where you are testing Subplans). That way, every other test is also testing reading, writing, and combining of Subplans. |
...s/services/query-metric/api/src/main/java/datawave/microservice/querymetric/QueryMetric.java
Outdated
Show resolved
Hide resolved
...ric/service/src/main/java/datawave/microservice/querymetric/handler/QueryMetricCombiner.java
Outdated
Show resolved
Hide resolved
...ric/service/src/main/java/datawave/microservice/querymetric/handler/QueryMetricCombiner.java
Outdated
Show resolved
Hide resolved
...rvices/query-metric/api/src/main/java/datawave/microservice/querymetric/BaseQueryMetric.java
Show resolved
Hide resolved
|
|
||
| public Map<String,RangeCounts> getSubPlans() { | ||
| return subPlans; | ||
| } | ||
|
|
||
| public void setSubPlans(Map<String,RangeCounts> subPlans) { | ||
| this.subPlans = subPlans; | ||
| } | ||
|
|
There was a problem hiding this comment.
Is the synchronized in addSubplan / addSubplans really necessary? If so, by returning the object in getSubplans, you are likely allowing non-synchronized access. Also, if multiple threads are accessing this calss, then setSubplans runs the risk of replacing the object that you have synchronized on. Or.... maybe you don't really have multile threads accessing a metric at the same time?
There was a problem hiding this comment.
I removed the synchronized. I do not think multiple threads are accessing a metric at the same time. But... this might need to be double checked.
...rvices/query-metric/api/src/main/java/datawave/microservice/querymetric/BaseQueryMetric.java
Outdated
Show resolved
Hide resolved
...uery-metric/api/src/main/java/datawave/microservice/querymetric/QueryMetricListResponse.java
Outdated
Show resolved
Hide resolved
...ry-metric/service/src/main/java/datawave/microservice/querymetric/QueryMetricOperations.java
Outdated
Show resolved
Hide resolved
microservices/services/query-metric/api/src/main/resources/templates/querymetric.html
Outdated
Show resolved
Hide resolved
...ce/src/main/java/datawave/microservice/querymetric/handler/ShardTableQueryMetricHandler.java
Outdated
Show resolved
Hide resolved
...ce/src/main/java/datawave/microservice/querymetric/handler/ShardTableQueryMetricHandler.java
Outdated
Show resolved
Hide resolved
...ce/src/main/java/datawave/microservice/querymetric/handler/ShardTableQueryMetricHandler.java
Show resolved
Hide resolved
3 participants
This PR is part of #1229
Adds:
This PR will need to be merged in before any other related PRs.